LakshSingla commented on code in PR #16853:
URL: https://github.com/apache/druid/pull/16853#discussion_r1706668352
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java:
##########
@@ -212,11 +212,10 @@ public void close() throws IOException
// Closeables are closed in LIFO order
closer.register(() -> {
org.apache.commons.io.FileUtils.forceDelete(chunkStorePath);
- LOG.info("Deleted chunkStorePath[%s]", chunkStorePath);
final long totalBytesUploaded = (currentChunk.id - 1) * chunkSize +
currentChunk.length();
final long totalUploadTimeMillis =
pushStopwatch.elapsed(TimeUnit.MILLISECONDS);
- LOG.info(
+ LOG.debug(
Review Comment:
can you call this method in `log.isDebugEnabled` instead? Computing the log
message is expensive and we don't wanna do that if the logging level isn't
`DEBUG`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
