clintropolis opened a new pull request, #16860: URL: https://github.com/apache/druid/pull/16860
Fixup `IndexedStringDruidPredicateIndexes` to just use a counter for index position since we are just iterating the dictionary. I have no idea why the code is like this since all of the other predicate index implementations were doing the sane thing already (though I've simplified them a bit in this PR since they were needlessly keeping separate position and matching position counters), perhaps there was a gas leak when I wrote the string one. I haven't measured it, but I assume this should be a large performance improvement for string predicate indexes since we don't have to binary search every matching value in the dictionary 🤦 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
