github-advanced-security[bot] commented on code in PR #16869:
URL: https://github.com/apache/druid/pull/16869#discussion_r1710309578
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchemaManager.java:
##########
@@ -56,6 +60,11 @@
return getTables().get(name);
}
+ default DruidTable getTable(String name, BrokerSegmentMetadataCache
segmentMetadataCache)
Review Comment:
## Useless parameter
The parameter 'segmentMetadataCache' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7702)
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchemaManager.java:
##########
@@ -56,6 +60,11 @@
return getTables().get(name);
}
+ default DruidTable getTable(String name, BrokerSegmentMetadataCache
segmentMetadataCache)
+ {
+ return getTables().get(name);
Review Comment:
## Deprecated method or constructor invocation
Invoking [DruidSchemaManager.getTables](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/1139)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
