FrankChen021 commented on PR #16821:
URL: https://github.com/apache/druid/pull/16821#issuecomment-2285399506
> > 1. What kind of response now is if such exception is raised?
> > 2. IMO, there's no need to provide a configuration to hide the error
stack, we can always hide the internal errors and show better messages. If we
design it in this way, in the future, we would have lots of configurations like
`showDetailedXXXError`
>
> Current error response looks something like this:
>
> ```
> {"error":"Cannot construct instance of
>
`org.apache.druid.indexing.common.task.batch.parallel.ParallelIndexIOConfig`,
> problem: At least one of properties[[firehose, inputSource]] must be
present\n at
> [Source: (org.eclipse.jetty.server.HttpInputOverHTTP); line: 1, column:
69] (through
> reference chain:
>
org.apache.druid.indexing.common.task.batch.parallel.ParallelIndexSupervisorTask[\"spe
> c\"]-
>
>org.apache.druid.indexing.common.task.batch.parallel.ParallelIndexIngestionSpec[\"ioC
> onfig\"])"}
> ```
>
> We added the flag because we may need to view detailed errors for
debugging or other purposes. Initially, we used `showDetailedJettyError`, but
that name was too specific to Jetty errors. To avoid such flag, I think we can
add a generic flag or live without it by adding detail message to logs only.
Thanks for the info.
For the debugging purpose, we can add these information to logs. For the
HTTP Response, we can keep only the info like:
```
Cannot construct instance of
`org.apache.druid.indexing.common.task.batch.parallel.ParallelIndexIOConfig`,
problem: At least one of properties[[firehose, inputSource]] must be present
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
