edgar2020 commented on code in PR #16862:
URL: https://github.com/apache/druid/pull/16862#discussion_r1716110745
##########
docs/querying/sql-functions.md:
##########
@@ -1414,11 +1562,32 @@ Returns the number of the row within the window
starting from 1.
## RPAD
-`RPAD(<CHARACTER>, <INTEGER>, [<CHARACTER>])`
+Returns a string of size `length` from `expr`. When the length of `expr` is
less than `length`, right pads `expr` with `chars`, which defaults to the space
character. Truncates `expr` to `length` if `length` is shorter than the length
of `expr`.
-**Function type:** [Scalar, string](sql-scalar.md#string-functions)
+* **Syntax:** `RPAD(expr, length[, chars])`
+* **Function type:** Scalar, string
+
+<details><summary>Example</summary>
+
+The following example inserts `+` characters as padding to the right of the
`OriginState` column from the `flight-carriers` datasource, making the return
expression a length of `5` characters.
+
+```sql
+SELECT
+ "OriginState" AS "origin_state",
+ RPAD("OriginState", 5, '+') AS "add_right_padding"
Review Comment:
Extended the same example so that it would cover adding padding, truncating,
and no change
##########
docs/querying/sql-functions.md:
##########
@@ -1085,19 +1085,63 @@ Looks up the expression in a registered query-time
lookup table.
## LOWER
-`LOWER(expr)`
+Returns the expression in lowercase.
-**Function type:** [Scalar, string](sql-scalar.md#string-functions)
+* **Syntax:** `LOWER(expr)`
+* **Function type:** Scalar, string
+
+<details><summary>Example</summary>
+
+The following example converts the `OriginCityName` column from the
`flight-carriers` datasource to lowercase.
+
+```sql
+SELECT
+ "OriginCityName" AS "origin_city",
+ LOWER("OriginCityName") AS "lowercase"
+FROM "flight-carriers"
+LIMIT 1
+```
+
+Returns the following:
+
+| `origin_city` | `lowercase` |
+| -- | -- |
+`San Juan, PR` | `san juan, pr` |
+
+</details>
+
+[Learn more](sql-scalar.md#string-functions)
-Returns the expression in lowercase.
## LPAD
-`LPAD(<CHARACTER>, <INTEGER>, [<CHARACTER>])`
+Returns a string of size `length` from `expr`. When the length of `expr` is
less than `length`, left pads `expr` with `chars`, which defaults to the space
character. Truncates `expr` to `length` if `length` is shorter than the length
of `expr`.
-**Function type:** [Scalar, string](sql-scalar.md#string-functions)
+* **Syntax:** `LPAD(expr, length[, chars])`
+* **Function type:** Scalar, string
+
+<details><summary>Example</summary>
+
+The following example left pads the value of `OriginState` from
`flight-carriers` to return a total of 5 characters.
+
+```sql
+SELECT
+ "OriginState" AS "origin_state",
+ LPAD("OriginState", 5, '+') AS "add_left_padding"
Review Comment:
Extended the same example so that it would cover adding padding, truncating,
and no change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
