FrankChen021 commented on code in PR #16878: URL: https://github.com/apache/druid/pull/16878#discussion_r1719211397
########## docs/querying/sql-functions.md: ########## @@ -1525,11 +1525,42 @@ Returns the following: ## LOOKUP -`LOOKUP(<CHARACTER>, <CHARACTER>[, <CHARACTER>])` +Searches for `expr` in a registered [query-time lookup table](lookups.md) named `lookupName` and returns the mapped value. If `expr` is null or not contained in the lookup, returns `replaceMissingValueWith` if supplied, otherwise returns null. -**Function type:** [Scalar, string](sql-scalar.md#string-functions) +* **Syntax:** `LOOKUP(expr, lookupName[, replaceMissingValueWith])` Review Comment: Can we use the name `defaultValue` for the 3rd parameter? I think it would be easier to understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
