Akshat-Jain opened a new pull request, #16906:
URL: https://github.com/apache/druid/pull/16906

   ### Description
   
   Currently, `TooManyRowsInAWindowFault` isn't propagated properly to the 
user. The user sees the following:
   
![image](https://github.com/user-attachments/assets/44565d7d-bfee-4cd9-b223-d267582d4c1a)
   
   Instead, the user should see the proper error message defined in 
`TooManyRowsInAWindowFault.java`. The issue was that 
`TooManyRowsInAWindowFault` wasn't added to the list of fault classes in 
MSQIndexingModule.
   
   With this PR's changes, `TooManyRowsInAWindowFault`'s error message is 
propagated properly to the end user:
   <img width="1463" alt="Screenshot 2024-08-16 at 12 43 10 PM" 
src="https://github.com/user-attachments/assets/f3f1464a-7fb5-48d8-89ba-91c55552f9c1";>
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to