pranavbhole commented on code in PR #16931:
URL: https://github.com/apache/druid/pull/16931#discussion_r1725981105


##########
processing/src/main/java/org/apache/druid/collections/spatial/ImmutableFloatNode.java:
##########
@@ -182,15 +182,15 @@ public ImmutableNode<float[]> next()
                   numDims,
                   initialOffset,
                   data.getInt(childrenOffset + (count++) * Integer.BYTES),
-                  data,
+                  data.duplicate(),

Review Comment:
   @clintropolis  Thank you Clint, I liked the suggestion as well as it can 
avoid creating duplicate references on each tree node and sometimes tree can be 
really big. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to