Akshat-Jain opened a new pull request, #16949:
URL: https://github.com/apache/druid/pull/16949

   ### Description
   
   Currently, MSQ WF drill test suite uses maxNumTasks: 2 (default).
   
   This means we can't detect any issues/regressions via this test, when we use 
multiple workers.
   
   This PR updates the MSQ WF drill test suite to use maxNumTasks: 5.
   
   However, there are some test cases which can give different correct results 
across different runs due to MixShuffleSpec being present in the previous 
stage. Such test cases have been overridden to use a single worker. This has 
been done for 8 tests.
   
   Some tests have been modified to give deterministic result, while ensuring 
that the test is still validating what it was originally added for.
   
   I've ran `MSQDrillWindowQueryTest` 10+ times locally to ensure no flakiness 
for any other test that's not overridden to use a single worker.
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to