jon-wei opened a new pull request, #16960: URL: https://github.com/apache/druid/pull/16960
This PR allows the `druid.azure.account` property to be nullable. `AzureStorageAccountInputSource` uses an injected `AzureAccountConfig` (used for configuring Azure deep storage) as a fallback configuration if the explicit input source configuration is not set. The non-nullable annotation on `account` causes problems when using `AzureStorageAccountInputSource` in a Druid cluster that does not use Azure deep storage and does not have that property set. The user should not have to set this property in that case. This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
