arunramani commented on code in PR #16972:
URL: https://github.com/apache/druid/pull/16972#discussion_r1735089965
##########
processing/src/main/java/org/apache/druid/java/util/metrics/OshiSysMonitor.java:
##########
@@ -105,10 +121,17 @@ public OshiSysMonitor(Map<String, String[]> dimensions,
String feed)
}
// Create an object with mocked systemInfo for testing purposes
+ @VisibleForTesting
public OshiSysMonitor(SystemInfo systemInfo)
+ {
+ this(systemInfo, ImmutableSet.of());
+ }
+
+ public OshiSysMonitor(SystemInfo systemInfo, Set<String> skipEmitting)
{
super("metrics");
this.dimensions = ImmutableMap.of();
+ this.skipEmitting = ImmutableSet.copyOf(skipEmitting);
Review Comment:
Is `ImmutableSet.copyOf` null safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
