cryptoe commented on code in PR #16987:
URL: https://github.com/apache/druid/pull/16987#discussion_r1740858649
##########
server/src/main/java/org/apache/druid/client/indexing/ClientCompactionRunnerInfo.java:
##########
@@ -137,7 +139,14 @@ public static CompactionConfigValidationResult
validatePartitionsSpecForMSQ(Part
return CompactionConfigValidationResult.failure(
"MSQ: Invalid partitioning type[%s]. Must be either 'dynamic' or
'range'",
partitionsSpec.getClass().getSimpleName()
-
+ );
+ }
+ if (partitionsSpec instanceof DimensionRangePartitionsSpec
+ && ((DimensionRangePartitionsSpec)
partitionsSpec).getTargetRowsPerSegment() == null) {
+ // Indicates maxRowsPerSegment is non-null. Cannot check directly for
maxRowsPerSegment==null since a resolved
+ // value is computed from targetRowsPerSegment.
+ return CompactionConfigValidationResult.failure(
+ "MSQ: 'maxRowsPerSegment' not supported with 'range' partitioning"
Review Comment:
Should we instruct the user to remove this config from the compaction spec
as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
