Akshat-Jain opened a new pull request, #17026: URL: https://github.com/apache/druid/pull/17026
### Description https://github.com/apache/druid/pull/16885 fixed issues with the following type of queries. ```sql -- Query 1 select countryName, cityName, channel, array_concat_agg(ARRAY['N/A', countryName], 10000) over (order by countryName) as c from wikipedia where countryName in ('Austria', 'Republic of Korea') and (cityName in ('Horsching', 'Vienna', 'Seoul', 'Jeonju') or cityName is null) group by countryName, cityName, channel -- This query used to give InvalidNullByteException for MSQ engine. -- Query 2 select countryName, array_concat_agg(ARRAY[countryName], 10000) over () as c1 from wikipedia where countryName='Guatemala' group by countryName -- This used to give the following incorrect result for both sql-native and MSQ engines: -- Guatemala [""\t""] ``` This PR adds the above queries as drill tests so that the behavior is validated against both engines. <hr> This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
