clintropolis commented on code in PR #17021: URL: https://github.com/apache/druid/pull/17021#discussion_r1753483553
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/input/table/SegmentWithMetadata.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.msq.input.table; + +import org.apache.druid.segment.Segment; +import org.apache.druid.timeline.DataSegment; + +import javax.annotation.Nullable; +import java.io.Closeable; +import java.io.IOException; +import java.util.Objects; + +/** + * Contains the {@link DataSegment} and {@link Segment}. The datasegment could be null if the segment is a dummy, such + * as those created by {@link org.apache.druid.msq.input.inline.InlineInputSliceReader}. + */ +public class SegmentWithMetadata implements Closeable Review Comment: `Segment` doesn't have `LoadSpec` or size or binary version; `LoadSpec` from `DataSegment` is how the `Segment` is made in the first place more or less, which I think is why this composite type seems a bit strange. `DataSegment` is the stuff to tell something to load the actual segment, so it seems kind of funny to drag it into processing. Maybe I don't understand the use case behind these changes enough since `DataSegment` isn't really used at all today for processing beyond loading the data, and it isn't really obvious what the need for `DataSegment` or its stuff like `LoadSpec` and binary version and stuff is to process data once you have the `Segment`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
