kgyrtkirk commented on code in PR #17029:
URL: https://github.com/apache/druid/pull/17029#discussion_r1754448262
##########
pom.xml:
##########
@@ -1778,6 +1778,9 @@
-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager
-Daws.region=us-east-1 <!-- required for
s3-related unit tests -->
-Ddruid.test.stupidPool.poison=true
+ <!-- the path needs to come from a maven option or
so -->
+ -XX:OnOutOfMemoryError='chmod 644
/home/runner/work/druid/druid/*.hprof'
Review Comment:
* you should try to avoid polluting the git worktree and explicit paths
* you could possibly use `${maven.multiModuleProjectDirectory} ` [1] or
similar to reference the root module's path
* try to place this under `target` so that it doesn't pollute the git
worktree with untracked files
[1]
https://stackoverflow.com/questions/3084629/finding-the-root-directory-of-a-multi-module-maven-reactor-project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
