pranavbhole commented on PR #16974: URL: https://github.com/apache/druid/pull/16974#issuecomment-2345180564
Yes, they are mapped as lowercase and stored in maps On Wed, Sep 11, 2024, 7:56 PM Abhishek Agarwal ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > processing/src/main/java/org/apache/druid/data/input/impl/HttpInputSource.java > <https://github.com/apache/druid/pull/16974#discussion_r1756022850>: > > > @@ -100,6 +98,27 @@ public static void throwIfInvalidProtocols(HttpInputSourceConfig config, List<UR > } > } > > + public static void throwIfForbiddenHeaders(HttpInputSourceConfig config, Map<String, String> requestHeaders) > + { > + if (config.getAllowedHeaders().size() > 0) { > + for (Map.Entry<String, String> entry : requestHeaders.entrySet()) { > + if (!config.getAllowedHeaders().contains(StringUtils.toLowerCase(entry.getKey()))) { > > are the keys in allowedHeaders always lower case? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/druid/pull/16974#pullrequestreview-2299119350>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABFU6HWTHE5CVEUTEYTOB5LZWD7GTAVCNFSM6AAAAABNJEAG2WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJZGEYTSMZVGA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
