cryptoe commented on code in PR #17025:
URL: https://github.com/apache/druid/pull/17025#discussion_r1756127415
##########
server/src/main/java/org/apache/druid/segment/metadata/CoordinatorSegmentMetadataCache.java:
##########
@@ -686,15 +696,21 @@ public RowSignature buildDataSourceRowSignature(final
String dataSource)
final Map<String, ColumnType> columnTypes = new LinkedHashMap<>();
if (segmentsMap != null && !segmentsMap.isEmpty()) {
- for (SegmentId segmentId : segmentsMap.keySet()) {
+ for (Map.Entry<SegmentId, AvailableSegmentMetadata> entry :
segmentsMap.entrySet()) {
+ SegmentId segmentId = entry.getKey();
Optional<SchemaPayloadPlus> optionalSchema =
segmentSchemaCache.getSchemaForSegment(segmentId);
if (optionalSchema.isPresent()) {
RowSignature rowSignature =
optionalSchema.get().getSchemaPayload().getRowSignature();
mergeRowSignature(columnTypes, rowSignature);
} else {
// mark it for refresh, however, this case shouldn't arise by design
- markSegmentAsNeedRefresh(segmentId);
log.debug("SchemaMetadata for segmentId [%s] is absent.", segmentId);
+
+ if (entry.getValue().getSegment().isTombstone()) {
Review Comment:
This block of code is repeated multiple times.
can be added in a method `markForRefreshifnottombstone`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
