clintropolis commented on code in PR #17057:
URL: https://github.com/apache/druid/pull/17057#discussion_r1759427475
##########
processing/src/main/java/org/apache/druid/query/groupby/GroupingEngine.java:
##########
@@ -469,13 +465,16 @@ public QueryRunner<ResultRow> mergeRunners(
* @param query the groupBy query
* @param cursorFactory cursor factory for the segment in question
* @param timeBoundaryInspector time boundary inspector for the segment in
question
+ * @param bufferPool processing buffer pool
+ * @param groupByQueryMetrics metrics instance, will be populated if
nonnull
*
* @return result sequence for the cursor factory
*/
public Sequence<ResultRow> process(
GroupByQuery query,
CursorFactory cursorFactory,
@Nullable TimeBoundaryInspector timeBoundaryInspector,
+ NonBlockingPool<ByteBuffer> bufferPool,
Review Comment:
it does feel kind of weird to pass in some resources to the process method
since like part of the resources are still associated with the engine via
`GroupByResourcesReservationPool`. I'm not entirely sure what is better to do
though, so i don't think this is a blocker or anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
