github-advanced-security[bot] commented on code in PR #17077:
URL: https://github.com/apache/druid/pull/17077#discussion_r1760823408
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerContext.java:
##########
@@ -104,8 +105,13 @@
WorkerClient newWorkerClient();
/**
- * Default target partitions per worker for {@link
QueryKit#makeQueryDefinition}. Can be overridden using
- * {@link MultiStageQueryContext#CTX_TARGET_PARTITIONS_PER_WORKER}.
+ * Create a {@link QueryKitSpec}. This method provides controller contexts a
way to customize parameters around the
+ * number of workers and partitions.
*/
- int defaultTargetPartitionsPerWorker();
+ QueryKitSpec makeQueryKitSpec(
+ QueryKit<Query<?>> queryKit,
+ String queryId,
+ MSQSpec querySpec,
+ ControllerQueryKernelConfig queryKernelConfig
Review Comment:
## Useless parameter
The parameter 'queryKernelConfig' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7908)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
