abhishekagarwal87 commented on code in PR #16672:
URL: https://github.com/apache/druid/pull/16672#discussion_r1760873130
##########
server/src/main/java/org/apache/druid/server/QueryResultPusher.java:
##########
@@ -120,7 +125,9 @@ public Response push()
final Response.ResponseBuilder startResponse = resultsWriter.start();
if (startResponse != null) {
- startResponse.header(QueryResource.QUERY_ID_RESPONSE_HEADER, queryId);
+ startResponse.header(QueryResource.QUERY_ID_RESPONSE_HEADER, queryId)
Review Comment:
Ah no. This header would not mean that the response is truncated. It would
mean that if the response is truncated, they can expect a corresponding
trailer. so client logic can be something like below
start reading response
if response_complete _trailer header is present
use the trailer logic to detect truncated response
else
use the existing mechanism to detect truncated response
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
