abhishekrb19 opened a new pull request, #17082: URL: https://github.com/apache/druid/pull/17082
Text-based input formats like `csv` and `tsv` currently parse inputs only as strings, following the `RFC4180Parser` spec). To workaround this, the web-console and other tools need to further inspect the sample data returned to sample data returned by the Druid sampler API to parse them as numbers. See [here](https://github.com/apache/druid/blob/master/web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx) for the relevant web-console code. Changes: - Introduce a new optional config `shouldParseNumbers` for the `csv` and `tsv` input formats. - If enabled, the input format reader will parse numeric values from the input string for these text-based input formats. - By default, this configuration is false for backwards compatibility - Note that when enabled, this can have a small performance hit as the input needs to be parsed to determined the numeric type. Docs and some more tests: TODO #### Release note: Introduce a new optional config, `shouldParseNumbers`, for the `csv` and `tsv` input formats.If enabled, any numbers present in the input will be parsed in the following manner -- `long` data type for integer types and `double` for floating-point numbers. By default, this configuration is set to false, so numeric strings will be treated as strings. - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [x] a release note entry in the PR description. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
