clintropolis opened a new pull request, #17084:
URL: https://github.com/apache/druid/pull/17084

   Adds methods to make it easier to check for equivalent virtual columns in 
the 'native' engine layer, even in cases where output names differ. This method 
isn't really used yet, but has some use cases in follow-up PRs.
   
   I have only implemented this method for `ExpressionVirtualColumn`, 
`NestedFieldVirtualColumn`, and `ListFilteredVirtualColumn` so far, and really 
only needed it for `ExpressionVirtualColumn`. The default implementation falls 
back to using equals, though I noticed a handful of implementations 
(`FallbackVirtualColumn`, `HashPartitionVirtualColumn`, and 
`SettableLongVirtualColumn`) do not implement that either. Given their 
use-cases, and the intended use-case of this method, I don't think it probably 
matters, though it should be easy enough to add them if we need it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to