LakshSingla commented on code in PR #17100: URL: https://github.com/apache/druid/pull/17100#discussion_r1772718355
########## docs/operations/metrics.md: ########## @@ -86,6 +86,7 @@ Most metric values reset each emission period, as specified in `druid.monitoring |`subquery/fallback/unknownReason/count`|Number of subqueries which cannot be materialized as frames due other reasons.|This metric is only available if the `SubqueryCountStatsMonitor` module is included.| | |`query/rowLimit/exceeded/count`|Number of queries whose inlined subquery results exceeded the given row limit|This metric is only available if the `SubqueryCountStatsMonitor` module is included.| | |`query/byteLimit/exceeded/count`|Number of queries whose inlined subquery results exceeded the given byte limit|This metric is only available if the `SubqueryCountStatsMonitor` module is included.| | +|`httpClient/channelAcquire/time`|Time in nannoseconds spent by the httpclient to acquire the channel.| | Review Comment: Sorry for being pedantic, but can you please make it more descriptive for the user and the operator? A few actionable items * What does `httpclient` mean here * What does channel mean here * nannoseconds is misspelled * /httpClient/channelAcquire/time-> httpClient/channelAcquire/timeNs * What is the normal value of this metric? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
