kfaraz commented on code in PR #17033:
URL: https://github.com/apache/druid/pull/17033#discussion_r1772732705
##########
indexing-service/src/test/java/org/apache/druid/indexing/compact/OverlordCompactionSchedulerTest.java:
##########
@@ -158,7 +158,10 @@ public void testCompactionSupervisorConfigSerde() throws
JsonProcessingException
OBJECT_MAPPER.writeValueAsString(ImmutableMap.of("enabled",
enabled, "engine", defaultEngine)),
CompactionSupervisorConfig.class
);
- Assert.assertEquals(new CompactionSupervisorConfig(enabled,
defaultEngine), compactionSupervisorConfig);
+ CompactionSupervisorConfig expectedConfig = new
CompactionSupervisorConfig(enabled, defaultEngine);
+ Assert.assertEquals(expectedConfig, compactionSupervisorConfig);
+ // Superfluous test to meet min branch coverage for
CompactionSupervisorSpec.
+ Assert.assertNotEquals(expectedConfig, "enabled");
Review Comment:
Nit: Best to have this test in a separate method.
Let's not call it superfluous as it does verify some code after all 😛
```suggestion
Assert.assertNotEquals(expectedConfig, new Object());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
