kfaraz commented on code in PR #16889:
URL: https://github.com/apache/druid/pull/16889#discussion_r1773405124
##########
docs/configuration/index.md:
##########
@@ -1135,6 +1135,7 @@ The following configs only apply if the Overlord is
running in remote mode. For
|`druid.indexer.runner.taskAssignmentTimeout`|How long to wait after a task
has been assigned to a Middle Manager before throwing an error.|`PT5M`|
|`druid.indexer.runner.minWorkerVersion`|The minimum Middle Manager version to
send tasks to. The version number is a string. This affects the expected
behavior during certain operations like comparison against
`druid.worker.version`. Specifically, the version comparison follows dictionary
order. Use ISO8601 date format for the version to accommodate date comparisons.
|"0"|
| `druid.indexer.runner.parallelIndexTaskSlotRatio`| The ratio of task slots
available for parallel indexing supervisor tasks per worker. The specified
value must be in the range `[0, 1]`. |1|
+|`druid.indexer.runner.taskSlotLimits`| A map where each key is a task type,
and the corresponding value represents the limit on the number of task slots
that a task of that type can occupy on a worker. The key is a `String` that
specifies the task type. The value can either be a Double or Integer. A
`Double` in the range [0, 1], representing a ratio of the available task slots
that tasks of this type can occupy. For example, a value of 0.5 means that
tasks of this type can occupy up to 50% of the task slots on a worker. A value
of 0 means that tasks of this type can occupy no slots. A value of 1.0 means no
restriction, allowing tasks of this type to occupy all available slots. An
`Integer` that is greater than or equal to 0, representing an absolute limit on
the number of task slots that tasks of this type can occupy. For example, a
value of 5 means that tasks of this type can occupy up to 5 task slots on a
worker. `taskSlotLimits = {"index_parallel": 0.5, "query_controller": 3}`.
In this example 'index_parallel' tasks can occupy up to 50% of task slots and
'query_controller' can occupy up to 3 task slots |Empty map|
Review Comment:
I don't think it is intuitive to put absolute limits and ratios in the same
property.
It would be better to have two separate properties.
Edit: Moreover, is this intended to be an absolute limit per worker or
overall?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
