This is an automated email from the ASF dual-hosted git repository.
karan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 152330c5a8e WorkerManager: Correct javadoc for "stop". (#17279)
152330c5a8e is described below
commit 152330c5a8ef23f4eac4202d660df7abe6153c19
Author: Gian Merlino <[email protected]>
AuthorDate: Tue Oct 8 03:19:43 2024 -0700
WorkerManager: Correct javadoc for "stop". (#17279)
The javadoc had a factual error: Dart's implementation does not in
fact always return immediately.
---
.../src/main/java/org/apache/druid/msq/exec/WorkerManager.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerManager.java
b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerManager.java
index 31af0953d2f..a4dc62aefd2 100644
---
a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerManager.java
+++
b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerManager.java
@@ -85,9 +85,11 @@ public interface WorkerManager
/**
* Stop all workers.
*
- * The task-based implementation blocks until all tasks exit. Dart's
implementation queues workers for stopping in
- * the background, and returns immediately. Either way, this method returns
quietly, no matter whether there was an
- * exception associated with the future from {@link #start()} or not.
+ * The task-based implementation blocks until all tasks exit. Dart's
implementation sends stop commands and waits
+ * for workers to exit if "interrupt" is true, otherwise it returns
immediately.
+ *
+ * Either way, this method returns quietly, no matter whether there was an
exception associated with the future
+ * from {@link #start()} or not.
*
* @param interrupt whether to interrupt currently-running work
*/
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
