abhishekrb19 commented on code in PR #17324:
URL: https://github.com/apache/druid/pull/17324#discussion_r1795982352
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerImpl.java:
##########
@@ -969,10 +969,11 @@ private StageOutputHolder
getOrCreateStageOutputHolder(final StageId stageId, fi
/**
* Returns cancellation ID for a particular stage, to be used in {@link
FrameProcessorExecutor#cancel(String)}.
+ * In addition to being a token for cancellation, this also appears in
thread dumps, so make it a little descriptive.
*/
private static String cancellationIdFor(final StageId stageId, final int
workerNumber)
{
- return StringUtils.format("%s_%s", stageId, workerNumber);
+ return StringUtils.format("dart-worker[%s_%s]", stageId, workerNumber);
Review Comment:
Is this useful for non-Dart workers too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
