Akshat-Jain commented on code in PR #17212:
URL: https://github.com/apache/druid/pull/17212#discussion_r1797155803
##########
extensions-core/lookups-cached-single/src/main/java/org/apache/druid/server/lookup/LoadingLookup.java:
##########
Review Comment:
> It fixes part of the issue. The frontend issue is not fixed in this PR.
However, we discovered that even if we bypass the frontend layer, there's still
a problem with the loading lookup since, after creation, we cannot use it,
having an error saying that lookup is not iterable. I already mentioned that in
the description.
When I was trying it out locally, I realized that the docs are probably
outdated, as `"connectorConfig":"jdbc://mysql://localhost:3306/my_data_base"`
needs to be specified in a JSON format instead of a string. The correct format
seems to be:
```json
"connectorConfig": {
"connectURI": "jdbc:mysql://localhost:3306/druid",
"user": "druid",
"password": "druid"
}
```
Were you able to create and use the lookup successfully without specifying
connectorConfig in the above JSON format?
> Should I remove the "fixes #xxxx" part or should I create a new Issue and
link it with the PR?
At this point, I think https://github.com/apache/druid/issues/15936 is more
of a UI + docs ticket. I'd suggest you can create a new ticket targeted for the
"iterating over the fetched data" part, and mention your use-case for the same
with an example query. Hope that works!
> Yes, if we want to see the content of the lookup, sometimes we need to
loop over all the data. And BTW, the loading lookup fails even if we use it
inside a query. We tested that on one of our Test environments and it was not
working. You can confirm this on your side also, that would be much
appreciated! These changes were tested on our Test environments and it's
working as expected so far.
Yes, I also did some local testing, the changes seem fine functionally! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
