findingrish commented on code in PR #17360: URL: https://github.com/apache/druid/pull/17360#discussion_r1805856601
########## processing/src/main/java/org/apache/druid/query/groupby/GroupByStatsProvider.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.groupby; + +import org.apache.druid.guice.LazySingleton; +import org.apache.druid.query.groupby.epinephelinae.LimitedTemporaryStorage; + +import javax.inject.Inject; +import java.util.Iterator; +import java.util.concurrent.ConcurrentLinkedQueue; +import java.util.concurrent.atomic.AtomicLong; + +/** + * Collects stats for group by queries like used merged buffer count, spilled bytes and group by resource acquisition time. + */ +@LazySingleton +public class GroupByStatsProvider +{ + private final AtomicLong resourceAcquisitionTimeNs = new AtomicLong(0); + private final AtomicLong resourceAcquisitionCount = new AtomicLong(0); + + private final ConcurrentLinkedQueue<LimitedTemporaryStorage> temporaryStorages; + + @Inject + public GroupByStatsProvider() + { + this.temporaryStorages = new ConcurrentLinkedQueue<>(); + } + + public synchronized void groupByResourceAcquisitionTimeNs(long delayNs) + { + resourceAcquisitionTimeNs.addAndGet(delayNs); + resourceAcquisitionCount.incrementAndGet(); + } + + public synchronized long getAndResetGroupByResourceAcquisitionStats() Review Comment: I couldn't find a way wherein I could report the sum and count together (so that any metric aggregation platform could automatically compute the averages). Are you suggesting to report two different metrics `groupBy/acquisitionTime` & `groupBy/acquisitionCount`? ########## docs/configuration/index.md: ########## @@ -401,7 +401,7 @@ Metric monitoring is an essential part of Druid operations. The following monito |`org.apache.druid.java.util.metrics.CgroupV2MemoryMonitor`| **EXPERIMENTAL** Reports memory usage from `memory.current` and `memory.max` files. Only applicable to `cgroupv2`.| |`org.apache.druid.server.metrics.HistoricalMetricsMonitor`|Reports statistics on Historical services. Available only on Historical services.| |`org.apache.druid.server.metrics.SegmentStatsMonitor` | **EXPERIMENTAL** Reports statistics about segments on Historical services. Available only on Historical services. Not to be used when lazy loading is configured.| -|`org.apache.druid.server.metrics.QueryCountStatsMonitor`|Reports how many queries have been successful/failed/interrupted.| +|`org.apache.druid.server.metrics.QueryCountStatsMonitor`|Reports how many queries have been successful/failed/interrupted. It also reports stats for group by queries.| Review Comment: I don't have strong opinions either, the only reason I merged them was an existing mergeBuffer metric in this monitor. I think a separate monitor would be better due to the added flexibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
