abhishekrb19 opened a new pull request, #17382: URL: https://github.com/apache/druid/pull/17382
This patch is extracted from [this PR](https://github.com/apache/druid/pull/17353) to make reviewing easier. It includes additional test coverage and javadocs compared to the original patch. **Changes**: - Added `BrokerClient` and `BrokerClientImpl` to the sql package that leverages the `ServiceClient` functionality; similar to `OverlordClient` and `CoordinatorClient` implementations in the server module. - For now, only two broker API stubs are added: `submitSqlTask()` and `fetchExplainPlanInformation()`. - Note that there is already a `org.apache.druid.discovery.BrokerClient` in the server module that's used by MSQE for a specific use case. This client has a weird contract though, and its retry mechanism is not robust. We should plan to remove it in the future, but for now, it has been marked as deprecated in favor of the new `BrokerClient` added in this patch. - Added a new POJO class `ExplainPlanInformation` that encapsulates explain plan info. Currently, the new `BrokerClient` is unused but will be utilized in [17353](https://github.com/apache/druid/pull/17353). This PR has: - [x] been self-reviewed. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
