abhishekrb19 commented on code in PR #17384:
URL: https://github.com/apache/druid/pull/17384#discussion_r1808187339
##########
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java:
##########
@@ -127,8 +123,6 @@ public CoordinatorDynamicConfig(
{
this.markSegmentAsUnusedDelayMillis =
markSegmentAsUnusedDelayMillis;
- this.mergeBytesLimit = mergeBytesLimit;
Review Comment:
Curious - were these configs never used, or was their actual usage removed
at some point, leaving just the configs in the code?
Also, I see these configs are referenced in a few places like the docs and
web-console:
https://github.com/apache/druid/blob/master/docs/configuration/index.md#dynamic-configuration,
https://github.com/apache/druid/blob/master/docs/api-reference/dynamic-configuration-api.md,
https://github.com/apache/druid/blob/master/web-console/src/druid-models/coordinator-dynamic-config/coordinator-dynamic-config.tsx#L33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
