abhishekrb19 commented on code in PR #17382:
URL: https://github.com/apache/druid/pull/17382#discussion_r1809014828
##########
server/src/main/java/org/apache/druid/rpc/guice/ServiceClientModule.java:
##########
@@ -117,4 +115,11 @@ public CoordinatorClient makeCoordinatorClient(
jsonMapper
);
}
+
+ public static ServiceClientFactory getServiceClientFactory(@EscalatedGlobal
final HttpClient httpClient)
Review Comment:
Ha, done. I also added Guice module tests to verify these instances are
provided, which should also address CI failures due to insufficient coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
