Akshat-Jain commented on code in PR #17411:
URL: https://github.com/apache/druid/pull/17411#discussion_r1815979753
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/MSQTasks.java:
##########
@@ -114,7 +114,13 @@ public static long
primaryTimestampFromObjectForInsert(final Object timestamp)
// be a long at execution time. So a nice user-friendly message isn't
needed here: it would only happen
// if the SQL layer is bypassed. Nice, friendly users wouldn't do that :)
final UnknownFault fault =
- UnknownFault.forMessage(StringUtils.format("Incorrect type for
[%s]", ColumnHolder.TIME_COLUMN_NAME));
+ UnknownFault.forMessage(
+ StringUtils.format(
+ "Incorrect type for column [%s]. Expected [Long] but got
[%s]. Please ensure the value is casted to [Long].",
Review Comment:
@LakshSingla I see, thanks for pointing this out!
I was trying to keep the error message format consistent for the user (for
example: `Expected [type1] but got [type2]` irrespective of whether these are
extrapolated or not, since the final message for the end user is what matters
IMO).
Have made the suggested change though, will keep this in mind for future as
well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
