abhishekrb19 commented on code in PR #17412:
URL: https://github.com/apache/druid/pull/17412#discussion_r1817319565
##########
.github/workflows/reusable-unit-tests.yml:
##########
@@ -117,23 +117,26 @@ jobs:
MAVEN_PROJECTS: ${{ inputs.maven_projects }}
run: ./.github/scripts/unit_tests_script.sh
- - name: Check for .hprof files on failure
+ - name: Check for dumps on failure
if: ${{ failure() }}
- id: check_for_heap_dump
+ id: check_for_dumps
run: |
- if ls ${GITHUB_WORKSPACE}/target/*.hprof 1> /dev/null 2>&1; then
- echo "found_hprof=true" >> "$GITHUB_ENV"
+ if test -n "$(find "${GITHUB_WORKSPACE}" \( -name '*.hprof' -or
-name 'hs_err_pid*' -or -name 'replay_pid*' -or -regex '.*/core\.[0-9]*' \))"
+ then
+ echo "found_dumps=true" >> "$GITHUB_ENV"
else
- echo "found_hprof=false" >> "$GITHUB_ENV"
+ echo "found_dumps=false" >> "$GITHUB_ENV"
fi
- - name: Collect tarball hprof dumps if they exist on failure
- if: ${{ failure() && env.found_hprof == 'true' }}
+ - name: Collect dumps if they exist on failure
+ if: ${{ failure() && env.found_dumps == 'true' }}
run: |
- tar cvzf ${RUNNER_TEMP}/hprof-dumps.tgz
${GITHUB_WORKSPACE}/target/*.hprof
+ find "${GITHUB_WORKSPACE}" \
+ \( -name '*.hprof' -or -name 'hs_err_pid*' -or -name 'replay_pid*'
-or -regex '.*/core\.[0-9]*' \) \
+ -exec tar -cvzf ${RUNNER_TEMP}/hprof-dumps.tgz {} +
Review Comment:
Perhaps just dumps or failure-dumps:
```suggestion
-exec tar -cvzf ${RUNNER_TEMP}/dumps.tgz {} +
```
##########
.github/workflows/reusable-unit-tests.yml:
##########
@@ -117,23 +117,26 @@ jobs:
MAVEN_PROJECTS: ${{ inputs.maven_projects }}
run: ./.github/scripts/unit_tests_script.sh
- - name: Check for .hprof files on failure
+ - name: Check for dumps on failure
if: ${{ failure() }}
- id: check_for_heap_dump
+ id: check_for_dumps
run: |
- if ls ${GITHUB_WORKSPACE}/target/*.hprof 1> /dev/null 2>&1; then
- echo "found_hprof=true" >> "$GITHUB_ENV"
+ if test -n "$(find "${GITHUB_WORKSPACE}" \( -name '*.hprof' -or
-name 'hs_err_pid*' -or -name 'replay_pid*' -or -regex '.*/core\.[0-9]*' \))"
+ then
+ echo "found_dumps=true" >> "$GITHUB_ENV"
else
- echo "found_hprof=false" >> "$GITHUB_ENV"
+ echo "found_dumps=false" >> "$GITHUB_ENV"
fi
- - name: Collect tarball hprof dumps if they exist on failure
- if: ${{ failure() && env.found_hprof == 'true' }}
+ - name: Collect dumps if they exist on failure
+ if: ${{ failure() && env.found_dumps == 'true' }}
run: |
- tar cvzf ${RUNNER_TEMP}/hprof-dumps.tgz
${GITHUB_WORKSPACE}/target/*.hprof
+ find "${GITHUB_WORKSPACE}" \
+ \( -name '*.hprof' -or -name 'hs_err_pid*' -or -name 'replay_pid*'
-or -regex '.*/core\.[0-9]*' \) \
+ -exec tar -cvzf ${RUNNER_TEMP}/hprof-dumps.tgz {} +
- name: Upload hprof dumps to GitHub if they exist on failure
- if: ${{ failure() && env.found_hprof == 'true' }}
+ if: ${{ failure() && env.found_dumps == 'true' }}
uses: actions/upload-artifact@master
with:
name: Hprof-${{ inputs.group }} hprof dumps (Compile=jdk${{
inputs.build_jdk }}, Run=jdk${{ inputs.runtime_jdk }})
Review Comment:
```suggestion
name: ${{ inputs.group }} dumps (Compile=jdk${{ inputs.build_jdk
}}, Run=jdk${{ inputs.runtime_jdk }})
```
the path below to `{{ runner.temp }}/dumps.tgz` to match the above.
##########
.github/workflows/reusable-unit-tests.yml:
##########
@@ -117,23 +117,26 @@ jobs:
MAVEN_PROJECTS: ${{ inputs.maven_projects }}
run: ./.github/scripts/unit_tests_script.sh
- - name: Check for .hprof files on failure
+ - name: Check for dumps on failure
if: ${{ failure() }}
- id: check_for_heap_dump
+ id: check_for_dumps
run: |
- if ls ${GITHUB_WORKSPACE}/target/*.hprof 1> /dev/null 2>&1; then
- echo "found_hprof=true" >> "$GITHUB_ENV"
+ if test -n "$(find "${GITHUB_WORKSPACE}" \( -name '*.hprof' -or
-name 'hs_err_pid*' -or -name 'replay_pid*' -or -regex '.*/core\.[0-9]*' \))"
+ then
+ echo "found_dumps=true" >> "$GITHUB_ENV"
else
- echo "found_hprof=false" >> "$GITHUB_ENV"
+ echo "found_dumps=false" >> "$GITHUB_ENV"
fi
- - name: Collect tarball hprof dumps if they exist on failure
- if: ${{ failure() && env.found_hprof == 'true' }}
+ - name: Collect dumps if they exist on failure
+ if: ${{ failure() && env.found_dumps == 'true' }}
run: |
- tar cvzf ${RUNNER_TEMP}/hprof-dumps.tgz
${GITHUB_WORKSPACE}/target/*.hprof
+ find "${GITHUB_WORKSPACE}" \
+ \( -name '*.hprof' -or -name 'hs_err_pid*' -or -name 'replay_pid*'
-or -regex '.*/core\.[0-9]*' \) \
+ -exec tar -cvzf ${RUNNER_TEMP}/hprof-dumps.tgz {} +
- name: Upload hprof dumps to GitHub if they exist on failure
Review Comment:
```suggestion
- name: Upload dumps to GitHub if they exist on failure
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
