yugvajani commented on code in PR #17325:
URL: https://github.com/apache/druid/pull/17325#discussion_r1819284799
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorSpecTest.java:
##########
@@ -310,71 +317,115 @@ public void testSerdeWithInputFormat() throws IOException
KafkaSupervisorSpec spec2 = mapper.readValue(serialized,
KafkaSupervisorSpec.class);
String stable = mapper.writeValueAsString(spec2);
+ String sortedStableJson = sortJsonString(stable);
Review Comment:
`could you point to the field which's comparision is the root cause of these
failures? are there any options there to alter the production code to be more
stable?` - The output of `dimensionSpec `was non-deterministic because the
parser wasn’t added to `dimensionSpec`, which led to ordering issues. I’ve
implemented a fix by adding a parser, similar to how other tests are set up,
which resolves the non-deterministic ordering problem. I’ve updated the PR with
this fix—please review it and let me know if it looks good. Now, the array's
ordering remains unchanged, but the dimension order is now deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
