georgew5656 commented on PR #17431: URL: https://github.com/apache/druid/pull/17431#issuecomment-2444777777
> Thanks for the changes, @georgew5656 ! I am not very well-versed with this code. Had a couple of questions. After your patch, we would only ever initialize the `logWatch` in `shutdown()`. When do we actually use this `logWatch`? > > Is the flow something like this? > > * `shutdown()` is called which initializes `logWatch` > * `join()` gets interrupted due to the shutdown > * the `finally` block of `join()` saves the task logs to a file (blocking until it finishes) yeah thats basically correct, its a way to (most of the time) save the logs when shutting down tasks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
