kgyrtkirk commented on code in PR #17354:
URL: https://github.com/apache/druid/pull/17354#discussion_r1822835963
##########
processing/src/main/java/org/apache/druid/query/QueryRunnerFactoryConglomerate.java:
##########
@@ -21,7 +21,9 @@
/**
*/
-public interface QueryRunnerFactoryConglomerate
+public interface QueryRunnerFactoryConglomerate extends QueryToolChestWarehouse
Review Comment:
I believe 2 things needs to be done here:
* remove `extends QueryToolChestWarehouse` and use
`QueryRunnerFactoryConglomerate`
* possibly remove the `QueryLogic` to be tied to the `QueryToolChest` like
it is now - so it will be valid to only specify that
* possibly introduce a new "map" for these things?
these will cause some refactors to happen - mostly in tests; I would like to
postpone that to a followup PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
