Akshat-Jain opened a new pull request, #17469: URL: https://github.com/apache/druid/pull/17469
### Description We plan to deprecate Java 8 as part of #17466. We ran into some issues with `intellij-inspections` check while doing that. On further discussion, we decided that we should remove intellij-inspections check for the following reasons: 1. `intellij-inspections` is coming from https://github.com/ccaominh/intellij-inspect, which is tied down to `openjdk8` image. 2. The image for `intellij-inspect` is published at https://hub.docker.com/r/ccaominh/intellij-inspect, which is outside of Apache infra. 3. The above project isn't being actively maintained. 4. We also have other checks (like `maven-checkstyle-plugin` and `spotbugs`) integrated in our CI pipeline which makes the `intellij-inspections` check redundant for the most part. On further looking into point (4), the `intellij-inspections` check does seem to provide some useful checks which aren't being covered in other static checks we have at the moment. So the plan is: 1. Remove `intellij-inspections` check. 2. Remove Java 8 support. 3. Explore other options like [Qodana](https://www.jetbrains.com/qodana/) and integrate them in the repo as a replacement for `intellij-inspections` check. <hr> This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
