kgyrtkirk commented on code in PR #17483:
URL: https://github.com/apache/druid/pull/17483#discussion_r1860208727
##########
processing/src/test/java/org/apache/druid/query/QueryContextTest.java:
##########
@@ -372,6 +372,20 @@ public void testDefaultEnableQueryDebugging()
assertTrue(QueryContext.of(ImmutableMap.of(QueryContexts.ENABLE_DEBUG,
true)).isDebug());
}
+ @Test
+ public void testDefaultIsDecoupled()
Review Comment:
update the testcase:
* renamed it to `testIsDecoupled`
* added check for when its set to `garbage`
I'm not sure what are the gains of having this as a string based setting;
I don't think it will have more variations...
it could be a boolean with the name like `decoupledMode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
