kfaraz commented on code in PR #17488:
URL: https://github.com/apache/druid/pull/17488#discussion_r1872528277
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorStateTest.java:
##########
@@ -1475,7 +1479,7 @@ public Duration getEmissionDuration()
Assert.assertTrue(supervisor.getNoticesQueueSize() == 0);
}
- @Test(timeout = 10_000L)
+ @Test(timeout = 60_000L)
Review Comment:
Nit: Why did we need to increase the timeout?
##########
services/src/main/java/org/apache/druid/cli/CliPeon.java:
##########
@@ -565,6 +553,28 @@ static void configureIntermediaryData(Binder binder)
shuffleClientBiddy.addBinding("deepstore").to(DeepStorageShuffleClient.class).in(LazySingleton.class);
}
+ static Map<String, Object> heartbeatDimensions(Task task)
+ {
+ ImmutableMap.Builder<String, Object> builder = ImmutableMap.builder();
+ builder.put(DruidMetrics.TASK_ID, task.getId());
+ builder.put(DruidMetrics.DATASOURCE, task.getDataSource());
+ builder.put(DruidMetrics.TASK_TYPE, task.getType());
+ builder.put(DruidMetrics.GROUP_ID, task.getGroupId());
+ Map<String, Object> tags = task.getContextValue(DruidMetrics.TAGS);
+ if (tags != null && !tags.isEmpty()) {
+ builder.put(DruidMetrics.TAGS, tags);
+ }
+
+ if (task instanceof SeekableStreamIndexTask) {
+ SeekableStreamIndexTask streamingTask = (SeekableStreamIndexTask) task;
+ if (streamingTask.getCurrentRunnerStatus() != null) {
+ builder.put(DruidMetrics.STATUS,
streamingTask.getCurrentRunnerStatus());
Review Comment:
This is not very likely to happen but the value of the
`getCurrentRunnerStatus()` could change between these two calls. Probably
better to assign it to a variable instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
