kfaraz commented on code in PR #17566:
URL: https://github.com/apache/druid/pull/17566#discussion_r1884086402
##########
server/src/main/java/org/apache/druid/server/compaction/DataSourceCompactibleSegmentIterator.java:
##########
@@ -491,10 +491,9 @@ static List<Interval> filterSkipIntervals(Interval
totalInterval, List<Interval>
remainingStart = skipInterval.getEnd();
} else {
// Ignore this skipInterval
- log.warn(
+ log.debug(
Review Comment:
this log doesn't provide much useful info and can remain a debug
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/HttpLoadQueuePeon.java:
##########
@@ -76,14 +76,10 @@
public class HttpLoadQueuePeon implements LoadQueuePeon
{
public static final TypeReference<List<DataSegmentChangeRequest>>
REQUEST_ENTITY_TYPE_REF =
- new TypeReference<List<DataSegmentChangeRequest>>()
- {
- };
+ new TypeReference<>() {};
Review Comment:
Java 9+ supports diamond operator with anonymous classes.
Since we have dropped support for Java 8, we can use this syntax here (and
in several other places in the code which can be done in a separate PR).
cc: @Akshat-Jain
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/HttpLoadQueuePeon.java:
##########
@@ -390,8 +386,10 @@ public void stop()
stopped = true;
// Cancel all queued requests
- queuedSegments.forEach(holder -> onRequestCompleted(holder,
RequestStatus.CANCELLED));
- log.info("Cancelled [%d] requests queued on server [%s].",
queuedSegments.size(), serverId);
+ if (!queuedSegments.isEmpty()) {
+ queuedSegments.forEach(holder -> onRequestCompleted(holder,
RequestStatus.CANCELLED));
+ log.info("Cancelled [%d] requests queued on server[%s].",
queuedSegments.size(), serverId);
Review Comment:
log only when non-empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
