Akshat-Jain commented on code in PR #17567:
URL: https://github.com/apache/druid/pull/17567#discussion_r1886328549
##########
processing/src/main/java/org/apache/druid/java/util/common/concurrent/ScheduledExecutors.java:
##########
@@ -47,14 +47,18 @@
exec,
initialDelay,
delay,
- new Callable<Signal>()
+ new Callable<>()
{
@Override
public Signal call()
{
runnable.run(); // (Exceptions are handled for us)
if (exec.isShutdown()) {
- log.warn("ScheduledExecutorService is ShutDown. Return
'Signal.STOP' and stopped rescheduling %s (delay %s)", this, delay);
+ log.warn(
+ "ScheduledExecutorService is ShutDown. Return 'Signal.STOP'
and stopped rescheduling %s (delay %s)",
+ this,
Review Comment:
Unrelated to this PR's code changes.
##########
processing/src/test/java/org/apache/druid/java/util/common/guava/ConcatSequenceTest.java:
##########
@@ -207,21 +207,21 @@
ImmutableList.of(4, 5, 6)
)
),
- new Function<ImmutableList<Integer>, Sequence<Integer>>()
+ new Function<>()
{
@Override
public Sequence<Integer> apply(final ImmutableList<Integer>
input)
{
if (lastSeqFullyRead.getAndSet(false)) {
return Sequences.simple(
- new Iterable<Integer>()
+ new Iterable<>()
Review Comment:
Unrelated to this PR's code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
