gianm commented on code in PR #17565:
URL: https://github.com/apache/druid/pull/17565#discussion_r1887723392
##########
processing/src/main/java/org/apache/druid/query/QueryContexts.java:
##########
@@ -89,6 +89,7 @@ public class QueryContexts
public static final String UNCOVERED_INTERVALS_LIMIT_KEY =
"uncoveredIntervalsLimit";
public static final String MIN_TOP_N_THRESHOLD = "minTopNThreshold";
public static final String CATALOG_VALIDATION_ENABLED =
"catalogValidationEnabled";
+ public static final String TOPN_USE_MULTI_PASS_POOLED_QUERY_GRANULARITY =
"topNuseMultiPassPooledQueryGranularity";
Review Comment:
Please add a javadoc comment here explaining what this is for, and linking
to this PR (or a related issue). It's helpful to have that kind of thing for
any undocumented parameter.
##########
integration-tests/src/test/resources/queries/twitterstream_queries.json:
##########
@@ -19,8 +19,8 @@
}
],
"context": {
- "useCache": "true",
- "populateCache": "true",
+ "useCache": "false",
Review Comment:
why change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
