Akshat-Jain commented on PR #17578: URL: https://github.com/apache/druid/pull/17578#issuecomment-2548062681
@kfaraz Thanks for the review! > Thanks for the changes, @Akshat-Jain ! Most of the stuff looks good. The `ExceptionMatcher` is very useful for readability of tests. Credits to @imply-cheddar for the original changes! 😄 > I have a couple of questions: > > * Do we not need the `guice-multibindings` dependency anymore? Where was it being used? Is it now coming packaged inside the other guice dependencies? Yeah. Since Guice 4.2, multibindings support has moved to Guice core. Reference: https://github.com/google/guice/wiki/Multibindings > * Are the changes made to `DruidCoreInjectorBuilder` required in this PR? I would prefer it if we tackled that improvement separately. Have reverted those changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
