weishiuntsai opened a new pull request, #17583: URL: https://github.com/apache/druid/pull/17583
This is the 2nd PR as the follow-up of the PR https://github.com/apache/druid/pull/17548. It migrates the remaining 6 sets of SQL tests to quidem. These 6 sets cover aggregation, array, json, mv, reduction, and other scalar functions. These tests use the existing kttm dataset. They aim to exercise SQL queries in a more comprehensive way: **Aggregation functions:** - Each aggregation function is exercised in 1 query shape: group by query - Each query covers all operators in the predicates of the `having` clause. - All queries are designed to return 7 rows. **Scalar functions:** - Each scalar function is exercised in 3 different query shapes: simple query subquery group by query - Each query covers all operators in the predicates of the `where` clause. - All queries are select count(*) queries. They are designed to all return the same result for easy maintenance and debugging. This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
