kfaraz commented on code in PR #17545:
URL: https://github.com/apache/druid/pull/17545#discussion_r1889562330
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -445,16 +448,14 @@ private void becomeLeader()
config.getCoordinatorPeriod()
)
);
- if (overlordClient != null) {
Review Comment:
In production code, `OverlordClient` was always non-null. It seems likely
that this has been added to handle some test cases in `DruidCoordinatorTest`.
But I have fixed that up so that we need not handle the null case anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
