cecemei commented on code in PR #17564:
URL: https://github.com/apache/druid/pull/17564#discussion_r1890947526
##########
processing/src/main/java/org/apache/druid/query/DataSource.java:
##########
@@ -118,6 +123,27 @@ public interface DataSource
*/
DataSource withUpdatedDataSource(DataSource newSource);
+ default DataSource mapWithRestriction(Map<String, Optional<DimFilter>>
rowFilters)
+ {
+ return mapWithRestriction(rowFilters, true);
+ }
+
+ /**
+ * Returns an updated datasource based on the policy restrictions on tables.
If this datasource contains no table, no
+ * changes should occur.
+ *
+ * @param rowFilters a mapping of table names to row filters, every table in
the datasource tree must have an entry
+ * @return the updated datasource, with restrictions applied in the
datasource tree
+ */
+ default DataSource mapWithRestriction(Map<String, Optional<DimFilter>>
rowFilters, boolean enableStrictPolicyCheck)
Review Comment:
yes strict check should happen. btw, i added this flag because some tests in
views are failing, which i assume won't be an easy solution to fix.
in theory if there's no views, we could default to strict check, it just
wants to see table has an entry in policyMap (could Optional.empty() if
authorizer says there's no policy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
