cecemei commented on code in PR #17564: URL: https://github.com/apache/druid/pull/17564#discussion_r1909320717
########## server/src/main/java/org/apache/druid/server/security/AuthorizationResult.java: ########## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server.security; + +import com.google.common.base.Preconditions; +import com.google.common.base.Strings; +import com.google.common.collect.ImmutableMap; +import org.apache.druid.error.DruidException; +import org.apache.druid.query.policy.Policy; + +import javax.annotation.Nonnull; +import javax.annotation.Nullable; +import java.util.Collections; +import java.util.Map; +import java.util.Objects; +import java.util.Optional; +import java.util.Set; + +/** + * Represents the outcoming of performing authorization check on required resource accesses on a query or http requests. + * It contains: + * <ul> + * <li>a boolean allow or deny access results for checking permissions on a list of resource actions. + * <li>a failure message if deny access. It's null when access is allowed. + * <li>a map of table name with optional {@link Policy} restriction. An empty value means there's no restriction + * enforced on the table. + * </ul> + */ +public class AuthorizationResult +{ + /** + * Provides access with no restrictions to all resources.This should be limited to Druid internal systems or + * superusers, except in cases where granular ACL considerations are not a priority. + */ + public static final AuthorizationResult ALLOW_NO_RESTRICTION = new AuthorizationResult( + PERMISSION.ALLOW_NO_RESTRICTION, + null, + Collections.emptyMap(), + null, + null + ); + + /** + * Provides a default deny access result. + */ + public static final AuthorizationResult DENY = new AuthorizationResult( + PERMISSION.DENY, + Access.DENIED.getMessage(), + Collections.emptyMap(), + null, + null + ); + + enum PERMISSION + { + ALLOW_NO_RESTRICTION, + ALLOW_WITH_RESTRICTION, + DENY + } + + private final PERMISSION permission; + + @Nullable + private final String failureMessage; + + private final Map<String, Optional<Policy>> policyRestrictions; + + @Nullable + private final Set<ResourceAction> sqlResourceActions; + + @Nullable + private final Set<ResourceAction> allResourceActions; Review Comment: removed sqlResourceActions and allResourceActions from AuthorizationResult -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
