This is an automated email from the ASF dual-hosted git repository.
carryxyh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new 8abd590 Fixed a minor issue with doConnect not using
getConnectTimeout() in NettyClient (#2595)
8abd590 is described below
commit 8abd59029e7c0bc0973b492fd84a386b26661bc7
Author: yizhenqiang <[email protected]>
AuthorDate: Tue Oct 9 11:57:52 2018 +0800
Fixed a minor issue with doConnect not using getConnectTimeout() in
NettyClient (#2595)
* Fixed a minor issue with doConnect not using getConnectTimeout() in
NettyClient
* Fixed some problems with connectTimeout, CONNECT_TIMEOUT_KEY, timeout,
and TIMEOUT_KEY being used incorrectly.
---
.../java/org/apache/dubbo/remoting/transport/AbstractClient.java | 2 +-
.../org/apache/dubbo/remoting/transport/grizzly/GrizzlyClient.java | 2 +-
.../java/org/apache/dubbo/remoting/transport/mina/MinaClient.java | 6 +++---
.../java/org/apache/dubbo/remoting/transport/netty/NettyClient.java | 2 +-
.../org/apache/dubbo/remoting/transport/netty4/NettyClient.java | 6 +++---
.../main/java/org/apache/dubbo/rpc/protocol/rest/RestProtocol.java | 2 +-
6 files changed, 10 insertions(+), 10 deletions(-)
diff --git
a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/AbstractClient.java
b/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/AbstractClient.java
index a945586..477fa71 100644
---
a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/AbstractClient.java
+++
b/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/AbstractClient.java
@@ -276,7 +276,7 @@ public abstract class AbstractClient extends
AbstractEndpoint implements Client
if (!isConnected()) {
throw new RemotingException(this, "Failed connect to server "
+ getRemoteAddress() + " from " + getClass().getSimpleName() + " "
+ NetUtils.getLocalHost() + " using dubbo version " +
Version.getVersion()
- + ", cause: Connect wait timeout: " + getTimeout() +
"ms.");
+ + ", cause: Connect wait timeout: " +
getConnectTimeout() + "ms.");
} else {
if (logger.isInfoEnabled()) {
logger.info("Successed connect to server " +
getRemoteAddress() + " from " + getClass().getSimpleName() + " "
diff --git
a/dubbo-remoting/dubbo-remoting-grizzly/src/main/java/org/apache/dubbo/remoting/transport/grizzly/GrizzlyClient.java
b/dubbo-remoting/dubbo-remoting-grizzly/src/main/java/org/apache/dubbo/remoting/transport/grizzly/GrizzlyClient.java
index 30f47b8..2753d21 100644
---
a/dubbo-remoting/dubbo-remoting-grizzly/src/main/java/org/apache/dubbo/remoting/transport/grizzly/GrizzlyClient.java
+++
b/dubbo-remoting/dubbo-remoting-grizzly/src/main/java/org/apache/dubbo/remoting/transport/grizzly/GrizzlyClient.java
@@ -66,7 +66,7 @@ public class GrizzlyClient extends AbstractClient {
.setMaxPoolSize(Integer.MAX_VALUE)
.setKeepAliveTime(60L, TimeUnit.SECONDS);
builder.setTcpNoDelay(true).setKeepAlive(true)
- .setConnectionTimeout(getTimeout())
+ .setConnectionTimeout(getConnectTimeout())
.setIOStrategy(SameThreadIOStrategy.getInstance());
transport = builder.build();
transport.setProcessor(filterChainBuilder.build());
diff --git
a/dubbo-remoting/dubbo-remoting-mina/src/main/java/org/apache/dubbo/remoting/transport/mina/MinaClient.java
b/dubbo-remoting/dubbo-remoting-mina/src/main/java/org/apache/dubbo/remoting/transport/mina/MinaClient.java
index 552becd..23296f7 100644
---
a/dubbo-remoting/dubbo-remoting-mina/src/main/java/org/apache/dubbo/remoting/transport/mina/MinaClient.java
+++
b/dubbo-remoting/dubbo-remoting-mina/src/main/java/org/apache/dubbo/remoting/transport/mina/MinaClient.java
@@ -78,7 +78,7 @@ public class MinaClient extends AbstractClient {
cfg.setThreadModel(ThreadModel.MANUAL);
cfg.getSessionConfig().setTcpNoDelay(true);
cfg.getSessionConfig().setKeepAlive(true);
- int timeout = getTimeout();
+ int timeout = getConnectTimeout();
cfg.setConnectTimeout(timeout < 1000 ? 1 : timeout / 1000);
// set codec.
connector.getFilterChain().addLast("codec", new
ProtocolCodecFilter(new MinaCodecAdapter(getCodec(), getUrl(), this)));
@@ -135,10 +135,10 @@ public class MinaClient extends AbstractClient {
}
});
try {
- finish.await(getTimeout(), TimeUnit.MILLISECONDS);
+ finish.await(getConnectTimeout(), TimeUnit.MILLISECONDS);
} catch (InterruptedException e) {
throw new RemotingException(this, "client(url: " + getUrl() + ")
failed to connect to server " + getRemoteAddress() + " client-side timeout "
- + getTimeout() + "ms (elapsed: " +
(System.currentTimeMillis() - start)
+ + getConnectTimeout() + "ms (elapsed: " +
(System.currentTimeMillis() - start)
+ "ms) from netty client " + NetUtils.getLocalHost() + "
using dubbo version "
+ Version.getVersion() + ", cause: " + e.getMessage(), e);
}
diff --git
a/dubbo-remoting/dubbo-remoting-netty/src/main/java/org/apache/dubbo/remoting/transport/netty/NettyClient.java
b/dubbo-remoting/dubbo-remoting-netty/src/main/java/org/apache/dubbo/remoting/transport/netty/NettyClient.java
index a91aa58..574402f 100644
---
a/dubbo-remoting/dubbo-remoting-netty/src/main/java/org/apache/dubbo/remoting/transport/netty/NettyClient.java
+++
b/dubbo-remoting/dubbo-remoting-netty/src/main/java/org/apache/dubbo/remoting/transport/netty/NettyClient.java
@@ -67,7 +67,7 @@ public class NettyClient extends AbstractClient {
// @see org.jboss.netty.channel.socket.SocketChannelConfig
bootstrap.setOption("keepAlive", true);
bootstrap.setOption("tcpNoDelay", true);
- bootstrap.setOption("connectTimeoutMillis", getTimeout());
+ bootstrap.setOption("connectTimeoutMillis", getConnectTimeout());
final NettyHandler nettyHandler = new NettyHandler(getUrl(), this);
bootstrap.setPipelineFactory(new ChannelPipelineFactory() {
@Override
diff --git
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClient.java
b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClient.java
index 48e669c..19b56ae 100644
---
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClient.java
+++
b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClient.java
@@ -66,10 +66,10 @@ public class NettyClient extends AbstractClient {
//.option(ChannelOption.CONNECT_TIMEOUT_MILLIS, getTimeout())
.channel(NioSocketChannel.class);
- if (getTimeout() < 3000) {
+ if (getConnectTimeout() < 3000) {
bootstrap.option(ChannelOption.CONNECT_TIMEOUT_MILLIS, 3000);
} else {
- bootstrap.option(ChannelOption.CONNECT_TIMEOUT_MILLIS,
getTimeout());
+ bootstrap.option(ChannelOption.CONNECT_TIMEOUT_MILLIS,
getConnectTimeout());
}
bootstrap.handler(new ChannelInitializer() {
@@ -90,7 +90,7 @@ public class NettyClient extends AbstractClient {
long start = System.currentTimeMillis();
ChannelFuture future = bootstrap.connect(getConnectAddress());
try {
- boolean ret = future.awaitUninterruptibly(3000,
TimeUnit.MILLISECONDS);
+ boolean ret = future.awaitUninterruptibly(getConnectTimeout(),
TimeUnit.MILLISECONDS);
if (ret && future.isSuccess()) {
Channel newChannel = future.channel();
diff --git
a/dubbo-rpc/dubbo-rpc-rest/src/main/java/org/apache/dubbo/rpc/protocol/rest/RestProtocol.java
b/dubbo-rpc/dubbo-rpc-rest/src/main/java/org/apache/dubbo/rpc/protocol/rest/RestProtocol.java
index 82883f4..2268b71 100644
---
a/dubbo-rpc/dubbo-rpc-rest/src/main/java/org/apache/dubbo/rpc/protocol/rest/RestProtocol.java
+++
b/dubbo-rpc/dubbo-rpc-rest/src/main/java/org/apache/dubbo/rpc/protocol/rest/RestProtocol.java
@@ -148,7 +148,7 @@ public class RestProtocol extends AbstractProxyProtocol {
connectionMonitor.addConnectionManager(connectionManager);
RequestConfig requestConfig = RequestConfig.custom()
- .setConnectTimeout(url.getParameter(Constants.TIMEOUT_KEY,
Constants.DEFAULT_TIMEOUT))
+
.setConnectTimeout(url.getParameter(Constants.CONNECT_TIMEOUT_KEY,
Constants.DEFAULT_CONNECT_TIMEOUT))
.setSocketTimeout(url.getParameter(Constants.TIMEOUT_KEY,
Constants.DEFAULT_TIMEOUT))
.build();
