This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch dev-metadata in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
commit 3de0ec03db4e0794100f840b3f354ef7d6d838bc Author: ken.lj <[email protected]> AuthorDate: Thu Nov 15 19:26:54 2018 +0800 Restore the previous behaviour --- .../java/org/apache/dubbo/common/extension/ExtensionLoader.java | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java b/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java index d69b6aa..1e9c538 100644 --- a/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java +++ b/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java @@ -806,9 +806,6 @@ public class ExtensionLoader<T> { codeBuilder.append("\nimport ").append(ExtensionLoader.class.getName()).append(";"); codeBuilder.append("\npublic class ").append(type.getSimpleName()).append("$Adaptive").append(" implements ").append(type.getCanonicalName()).append(" {"); - codeBuilder.append("\nprivate static final org.apache.dubbo.common.logger.Logger logger = org.apache.dubbo.common.logger.LoggerFactory.getLogger(ExtensionLoader.class);"); - codeBuilder.append("\nprivate java.util.concurrent.atomic.AtomicInteger count = new java.util.concurrent.atomic.AtomicInteger(0);\n"); - for (Method method : methods) { Class<?> rt = method.getReturnType(); Class<?>[] pts = method.getParameterTypes(); @@ -940,12 +937,8 @@ public class ExtensionLoader<T> { type.getName(), Arrays.toString(value)); code.append(s); - s = String.format("\n%s extension = null;\n try {\nextension = (%<s)%s.getExtensionLoader(%s.class).getExtension(extName);\n}catch(Exception e){\n", + s = String.format("\n%s extension = (%<s)%s.getExtensionLoader(%s.class).getExtension(extName);", type.getName(), ExtensionLoader.class.getSimpleName(), type.getName()); - s += String.format("if (count.incrementAndGet() == 1) {\nlogger.warn(\"Failed to find extension named \" + extName + \" for type %s, will use default extension %s instead.\", e);\n}\n", - type.getName(), defaultExtName); - s += String.format("extension = (%s)%s.getExtensionLoader(%s.class).getExtension(\"%s\");\n}", - type.getName(), ExtensionLoader.class.getSimpleName(), type.getName(), defaultExtName); code.append(s); // return statement
